Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a display of isRegularExcavation and date #509

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

ejimsan
Copy link
Member

@ejimsan ejimsan commented Nov 14, 2024

No description provided.

@ejimsan ejimsan requested a review from khoidt November 14, 2024 14:35
return this.toLocaleString()
}

toLocaleString(locale = 'default'): string {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function toLocaleString has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Copy link

codeclimate bot commented Nov 18, 2024

Code Climate has analyzed commit bda620d and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 87.5% (75% is the threshold).

This pull request will bring the total coverage in the repository to 90.9% (0.0% change).

View more on Code Climate.

@khoidt khoidt merged commit 4669503 into master Nov 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants