-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add research projects #513
base: master
Are you sure you want to change the base?
Conversation
import { ResearchProjects } from 'research-projects/researchProject' | ||
import TableOfContents from 'research-projects/subpages/aluGeneva/TableOfContents' | ||
|
||
export default function PageContent({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 3 locations. Consider refactoring.
import { ResearchProjects } from 'research-projects/researchProject' | ||
import TableOfContents from 'research-projects/subpages/amps/TableOfContents' | ||
|
||
export default function PageContent({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 3 locations. Consider refactoring.
import { SearchResult } from 'fragmentarium/ui/search/FragmentariumSearchResult' | ||
import PageContent from 'research-projects/subpages/aluGeneva/PageContent' | ||
|
||
export default function Search({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 3 locations. Consider refactoring.
import { SearchResult } from 'fragmentarium/ui/search/FragmentariumSearchResult' | ||
import PageContent from 'research-projects/subpages/amps/PageContent' | ||
|
||
export default function Search({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 3 locations. Consider refactoring.
src/router/researchProjectRoutes.tsx
Outdated
)} | ||
{...(sitemap && sitemapDefaults)} | ||
/>, | ||
<Route |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 3 locations. Consider refactoring.
import TocLink from 'research-projects/subpages/TocLink' | ||
import 'research-projects/ResearchProjects.sass' | ||
|
||
function AluGenevaTocLink({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 3 locations. Consider refactoring.
import TocLink from 'research-projects/subpages/TocLink' | ||
import 'research-projects/ResearchProjects.sass' | ||
|
||
function AmpsTocLink({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 3 locations. Consider refactoring.
</ExternalLink>{' '} | ||
to learn more about the project. | ||
</p> | ||
<div className={'project-page__search'}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 3 locations. Consider refactoring.
return <TocLink {...props} href={href} /> | ||
} | ||
|
||
export default function TableOfContents(): JSX.Element { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 3 locations. Consider refactoring.
return <TocLink {...props} href={href} /> | ||
} | ||
|
||
export default function TableOfContents(): JSX.Element { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 3 locations. Consider refactoring.
Code Climate has analyzed commit a446f70 and detected 15 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 26.3% (75% is the threshold). This pull request will bring the total coverage in the repository to 90.8% (-0.1% change). View more on Code Climate. |
No description provided.