frontend layer refactoring

[markus2330]

Tasks

• check duplicate code: polygon
• testability: extract methods into util files to make it easier to test simple methods
• selection of elements in konva (currently there is duplicated code in multiple layers #1329
• refactoring of store: some features should have an own store (e.g timeline)
• left toolbar form: common code for added/removed and notes #1328

Common operations of elements:

• selection
• transformation
• undo
• ???

Use case

shade and drawing layer

Related Pull request

No response

[markus2330]

As first step, please collect which operations might be sharable between layers.

[Bushuo]

I would strongly agree to a refactor of the MapStore into a more narrow layer specific store.
Also maybe a Stage and Transformer store.
This way more logic can be pulled from components into the respective stores and makes it easier to track where what happens.

A design pattern I would strongly encourage then is grouping actions under a actions namespace inside the store.

[Bushuo]

@badnames Can you please also explain, why a stage listeners functionality was needed?

PermaplanT/frontend/src/features/map_planning/components/BaseStage.tsx

Line 34 in 9f142c5

listeners?: {

Currently it seems a bit convoluted this way.
If you look at the plant layer

PermaplanT/frontend/src/features/map_planning/layers/plant/PlantsLayer.tsx

Line 215 in 9f142c5

useMapStore.getState().stageRef.current?.on('click.placePlant', handleCreatePlanting);

there is a backed-in functionality to listen to native Stage events.
Maybe I am missing something?

[markus2330]

@Bushuo thx for your great input!

A design pattern I would strongly encourage then is grouping actions under a actions namespace inside the store.

Can you maybe describe what you have in mind in our architecture documentation as a separate PR?

Can you please also explain

I created a separate issue #1155 as @badnames sometimes does not get all the notification. The extra issue will pop up in the sprint and I can ask him in the meeting.

I suggest that we should have a dedicated meeting together to discuss the frontend layer refactoring. But first we should have a PR that proposes an architecture. I think they (@badnames and @danielsteinkogler) will be very happy if you (@Bushuo) make specific suggestions.