Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

use stage listeners #1155

Open
markus2330 opened this issue Jan 9, 2024 · 3 comments
Open

use stage listeners #1155

markus2330 opened this issue Jan 9, 2024 · 3 comments
Assignees
Labels
refactor improve code without functional changes

Comments

@markus2330
Copy link
Contributor

@badnames Can you please also explain, why a stage listeners functionality was needed?


Currently it seems a bit convoluted this way.
If you look at the plant layer
useMapStore.getState().stageRef.current?.on('click.placePlant', handleCreatePlanting);
there is a backed-in functionality to listen to native Stage events.
Maybe I am missing something?

Originally posted by @Bushuo in #1152 (comment)

@markus2330 markus2330 added the question Further information is requested label Jan 9, 2024
@markus2330 markus2330 moved this to In Progress in PermaplanT Jan 15, 2024
@markus2330
Copy link
Contributor Author

Maybe I am missing something?

No, you are right 👍 It should be changed.

@markus2330 markus2330 added refactor improve code without functional changes and removed question Further information is requested labels Jan 15, 2024
@markus2330 markus2330 changed the title stage listeners? use stage listeners Jan 15, 2024
@markus2330 markus2330 moved this from In Progress to Current Sprint in PermaplanT Jan 15, 2024
@markus2330 markus2330 moved this from Current Sprint to Current Milestone in PermaplanT Mar 10, 2024
@badnames
Copy link
Member

badnames commented Mar 21, 2024

This was already removed in some branch, although it has not found its way into master yet.

@markus2330
Copy link
Contributor Author

Isn't it in #1135?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor improve code without functional changes
Projects
Status: Current Milestone
Development

No branches or pull requests

2 participants