Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

962 refactor and test timeline #1263

Merged
merged 8 commits into from
Apr 22, 2024
Merged

Conversation

danielsteinkogler
Copy link
Contributor

Basics

  • The PR is rebased with current master
  • I added a line to changelog.md
  • Details of what I changed are in the commit messages
  • References to issues, e.g. close #X, are in the commit messages and changelog
  • The buildserver is happy

Checklist

  • I fully described what my PR does in the documentation
  • I fixed all affected documentation
  • I fixed the introduction tour
  • I wrote migrations in a way that they are compatible with already present data
  • I fixed all affected decisions
  • I added automated tests or a manual test protocol
  • I added code comments, logging, and assertions as appropriate
  • I translated all strings visible to the user
  • I mentioned every code or binary not directly written or done by me in reuse syntax
  • I created left-over issues for things that are still to be done
  • Code is conforming to our Architecture
  • Code is conforming to our Guidelines
  • Code is consistent to our Design Decisions
  • Exceptions to any guidelines are documented

First Time Checklist

Review

  • I've tested the code
  • I've read through the whole code
  • I've read through the whole documentation
  • I've checked conformity to guidelines
  • I've checked conformity to requirements
  • I've checked that the requirements are tested

@danielsteinkogler
Copy link
Contributor Author

jenkins build please

@danielsteinkogler danielsteinkogler marked this pull request as ready for review April 8, 2024 14:33
@danielsteinkogler danielsteinkogler added the please review Review by unspecified person requested label Apr 8, 2024
@markus2330
Copy link
Contributor

Thx! Please request other reviews first. Especially the map store and the docu for it.

We found an unrelated problem: #1267

Copy link
Contributor

@hatchla hatchla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, I support this approach of seperating the state stores. Nice solution!

  • I've tested the code
  • I've read through the whole code
  • I've read through the whole documentation
  • I've checked conformity to guidelines
  • I've checked conformity to requirements
  • I've checked that the requirements are tested

Copy link
Contributor

@andreicristian97 andreicristian97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, nicely done!

  • I've tested the code
  • I've read through the whole code
  • I've read through the whole documentation
  • I've checked conformity to guidelines
  • I've checked conformity to requirements
  • I've checked that the requirements are tested

@danielsteinkogler
Copy link
Contributor Author

Here is the followup issue to update architecture: #1331

@danielsteinkogler danielsteinkogler added please merge and removed please review Review by unspecified person requested labels Apr 22, 2024
@markus2330 markus2330 merged commit b6ddfb3 into master Apr 22, 2024
1 check passed
@markus2330 markus2330 deleted the 962-refactor-and-test-timeline branch April 22, 2024 16:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants