Sendpay with blindedpath #7493
Draft
Sendpay with blindedpath #7493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the possiblity to parse from command line arguments a struct blinded_path. Signed-off-by: Lagrang3 <[email protected]>
Signed-off-by: Lagrang3 <[email protected]>
Signed-off-by: Lagrang3 <[email protected]>
Signed-off-by: Lagrang3 <[email protected]>
Uniformly serialize blinded paths' field "path" instead of "hops". Signed-off-by: Lagrang3 <[email protected]>
Lagrang3
commented
Jul 29, 2024
| @@ -35,7 +35,7 @@ json_to_blinded_path(const tal_t *ctx, const char *buffer, const jsmntok_t *tok) | |||
| else | |||
| sciddir_or_pubkey_from_pubkey(&rpath->first_node_id, &first_node_id); | |||
|
|
|||
| hops = json_get_member(buffer, tok, "hops"); | |||
| hops = json_get_member(buffer, tok, "path"); | |||
There was a problem hiding this comment.
@rustyrussell: I am not sure about this, should it be "hops" or "path".
Signed-off-by: Lagrang3 <[email protected]>
Signed-off-by: Lagrang3 <[email protected]>
|
There are some files autogenerated after I hit some of which are related to my changes, but others are not. I don't know if I should commit them too. |
Changelog-Added: offers: sendpay RPC now accepts a blinded paths to execute a BOLT12 payment. Signed-off-by: Lagrang3 <[email protected]>
Signed-off-by: Lagrang3 <[email protected]>
|
I had a mistake in the schema, rebased on top of that commit. |
Lagrang3
force-pushed
the
sendpay-with-blindedpath
branch
from
62c34ed
to
f0f8b42
Compare
Signed-off-by: Lagrang3 <[email protected]>
|
doc/index.rst looks new to me but i think that's ok. Rest is business as usual if you change something in the schema. |
Signed-off-by: Lagrang3 <[email protected]>
|
Related to #6609. |
|
I am going to archive this for the moment. A new way of making payments has come out with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra arguments to
sendpayto handle bolt12's blinded paths.