msggen: add missing methods for 24.11 #7549
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daywalker90
force-pushed
the
msggen-askrene
branch
from
607a9a0
to
975a16c
Compare
This was referenced Aug 11, 2024
|
I'm going to defer these because they're still experimental and I want to reserve the right to change them radically! Maybe by the time we're into next release @Lagrang3 and I will have more confidence? |
Changelog-None
daywalker90
force-pushed
the
msggen-askrene
branch
from
975a16c
to
c0fb3e3
Compare
daywalker90
changed the title
Changelog-None
daywalker90
force-pushed
the
msggen-askrene
branch
from
c0fb3e3
to
4968fdb
Compare
cdecker
approved these changes
Nov 9, 2024
|
Ack 4968fdb Several other PRS will conflict (damn generated files) so I'll wait a bit before rebasing and merging this |
|
Want me to do a separate PR for the rest or add them here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to fall out of sync again, right?! @rustyrussell @ShahanaFarooqui
EDIT: reworked the PR to include all the missing rpc commands for 24.11:
Still missing:
listaddresses#7800