Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: Next version update to 24.11 #7646

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Makefile: Next version update to 24.11 #7646

merged 4 commits into from
Sep 18, 2024

Conversation

ShahanaFarooqui
Copy link
Collaborator

Changelog-None.

@niftynei
Copy link
Collaborator

niftynei commented Sep 6, 2024

Seems like there's an unrelated test flake

**BROKEN** lightningd: DEPRECATED API USED rest-port.clnrest-prefix 
lightningd-1 2024-09-06T17:34:34.298Z UNUSUAL lightningd: Option rest-port=36301 deprecated in v23.11, renaming to clnrest-port=36301
lightningd-1 2024-09-06T17:34:34.298Z **BROKEN** lightningd: DEPRECATED API USED rest-host.clnrest-prefix 
lightningd-1 2024-09-06T17:34:34.298Z UNUSUAL lightningd: Option rest-host=127.0.0.1 deprecated in v23.11, renaming to clnrest-host=127.0.0.1

@ShahanaFarooqui ShahanaFarooqui force-pushed the next-version-update branch 4 times, most recently from 1f2805e to 3a5b3d9 Compare September 10, 2024 06:09
@ShahanaFarooqui
Copy link
Collaborator Author

@niftynei CI is fixed after adjusting some tests due to updated next cln release version. Please review and ACK now.

vincenzopalazzo
vincenzopalazzo requested changes Sep 13, 2024
View reviewed changes
.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
doc/contribute-to-core-lightning/release-checklist.md Show resolved Hide resolved
tests/test_gossip.py Show resolved Hide resolved
@rustyrussell
Copy link
Contributor

I reversed the order of commits to put CI changes first.

@ShahanaFarooqui
test: CI error fixes
4520554 
- Removes CI value error for Broken logs
- Fixes CI errors due to deprecated listconfigs 'important-plugins'
- Removed listchannels deprecated local test

Changelog-None.
@ShahanaFarooqui
doc: Pull request template update
ddc0d64
@ShahanaFarooqui
doc: Release checklist update
db5904b
@ShahanaFarooqui
Makefile: Next version updated to 24.11
03eab8a 
Changelog-None.
@rustyrussell rustyrussell merged commit 75c616c into ElementsProject:master Sep 18, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustyrussell rustyrussell Awaiting requested review from rustyrussell

@niftynei niftynei Awaiting requested review from niftynei

@vincenzopalazzo vincenzopalazzo Awaiting requested review from vincenzopalazzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShahanaFarooqui @niftynei @rustyrussell @vincenzopalazzo