Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: generate and install requirements.txt files for Python plugins #7864

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Makefile: generate and install requirements.txt files for Python plugins #7864

wants to merge 1 commit into from

Conversation

rustyrussell
Copy link
Contributor

Doesn't automate the install, but at least provides some tools for users to install the requirements on their systems

See-also: #7665

@rustyrussell @vincenzopalazzo
Makefile: generate and install requirements.txt files for Python plug…
17722fd 
…ins.

Doesn't automate the install, but at least provides some tools for users
to install the requirements on their systems

See-also: ElementsProject#7665
Changelog-None: Makefile: generate and install requirements.txt files for Python plugins.
Co-Developed-by: Vincenzo Palazzo <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
vincenzopalazzo
vincenzopalazzo approved these changes Nov 24, 2024
View reviewed changes
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 17722fd

Modified the commit body to make the CI happy, now lets wait the CI

@vincenzopalazzo
Copy link
Collaborator

some of the CI failure liek the mac os looks like unrelated

tools/generate-wire.py --page impl tools/test/test_gen.h test_type < tools/test/test_cases > tools/test/test_gen.c
echo '#include "test_gen.h"' > tools/test/print_gen.c
tools/generate-wire.py -P --page impl tools/test/print_gen.h test_type < tools/test/test_cases >> tools/test/print_gen.c
xgettext plugins/bkpr/statements_gettextgen.po
sql-rewrite plugins/bkpr/db_sqlite3_sqlgen.c
sql-rewrite plugins/bkpr/db_postgres_sqlgen.c
genidx doc/index.rst
cd plugins/wss-proxy && poetry export --without-hashes > ../../plugins/wss-proxy-requirements.txt
/bin/sh: poetry: command not found
rm external/build-arm64-apple-darwin23.6.0/libwally-core-build/src/secp256k1/libsecp256k1.la
make: *** [plugins/wss-proxy-requirements.txt] Error 127

@rustyrussell rustyrussell added this to the v25.02 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenzopalazzo vincenzopalazzo vincenzopalazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v25.02
Development

Successfully merging this pull request may close these issues.
2 participants
@rustyrussell @vincenzopalazzo