Skip to content

pyln-client: Adding disableoffer, enableoffer, fetchinvoice, listoffers and offer commands #8178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

21M4TW
Copy link

@21M4TW 21M4TW commented Mar 27, 2025

Important

25.02 FREEZE JANUARY 31ST: Non-bugfix PRs not ready by this date will wait for 25.05.

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.

@21M4TW 21M4TW requested a review from cdecker as a code owner March 27, 2025 01:38
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f1c4467

The only missing thing in here is to remove the merge commit

@ShahanaFarooqui ShahanaFarooqui added this to the v25.05 milestone Apr 15, 2025
@ShahanaFarooqui ShahanaFarooqui changed the title Changelog-Added: Adding offer-related commands to pyln-client, includ… pyln-client: Adding disableoffer, enableoffer, fetchinvoice, listoffers and offer commands Apr 30, 2025
@ShahanaFarooqui ShahanaFarooqui dismissed vincenzopalazzo’s stale review April 30, 2025 16:49

Re-based the PR on Master.

@ShahanaFarooqui
Copy link
Collaborator

@21M4TW Thanks for opening the PR! Just two quick suggestions for future contributions:

  • Please use git rebase instead of merge for your commits.
  • The preferred place for changelog entries is in the commit/PR description. You can find guidelines on choosing the right format here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants