-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spaces #1094
base: master
Are you sure you want to change the base?
Spaces #1094
Conversation
``` Could not log "request.rsolr" event. NameError: uninitialized constant Sunspot::Rails::LogSubscriber::BOLD ```
…current space when browsing
…ain circumstances
Allow icons to be re-coloured per-theme. Allow theme to be selected on space
existing_items_method: :administrators %> | ||
|
||
<div class="form-group"> | ||
<%= f.submit ( f.object.new_record? ? "Register" : "Update") + " space", class: 'btn btn-primary' %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go through i18n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a brief scan (view mostly) to locate spots where I saw some strings that don't go through i18n.
Create space | ||
<% end %> | ||
<% end %> | ||
<%= info_button("What are spaces?", hide_text: true) do %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This (and following line) should go through i18n
<div class="text-right my-3"> | ||
<% if policy(:space).create? %> | ||
<%= link_to new_space_path, class: 'btn btn-primary' do %> | ||
Create space |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go through i18n
@@ -0,0 +1,3 @@ | |||
<%= info_box('What are space?') do %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i18n
@@ -0,0 +1,12 @@ | |||
<%- model_class = Space -%> | |||
<div class="page-header"> | |||
<%= page_title(t('.title', default: [:'helpers.titles.new', 'New %{model}'], model: model_class.model_name.human.titleize.downcase)) %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i18n
Summary of changes
Host
header of the HTTP request. If no space exists for that host, the Default Space is set.Motivation and context
Part of the mTeSS-X OSCARS project.
Screenshots
Checklist
to license it to the TeSS codebase under the
BSD license.