Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash loading STL file #566

Open
Timmmm opened this issue Sep 9, 2024 · 4 comments
Open

Crash loading STL file #566

Timmmm opened this issue Sep 9, 2024 · 4 comments

Comments

@Timmmm
Copy link

Timmmm commented Sep 9, 2024

Using the Windows binary download from Sourceforge, compiled on Feb 7 2024, I opened this STL file:

bar.zip

Elmer then crashes.

By the way the UX of loading meshes is not great:

  1. There's File->Open and File->Load Mesh. Apparently to load a mesh you use File->Open, not File->Load Mesh?? And for some reason File->Open opens a file and File->Load Mesh opens a directory... Very confusing.
  2. Neither option lists the file formats that it supports. Fair enough for File->Load Mesh, but File->Open definitely should!
  3. I initially tried to load bar.STL (Solidworks' default extension), and very luckily I noticed the message in the status bar saying "make sure the file extension is lowercase", but I very easily could have missed that, and why do I even need to do that anyway? Just lowercase it yourself if you need to! At the very least you can detect if it isn't lowercase and throw up a modal error.
@Timmmm
Copy link
Author

Timmmm commented Sep 9, 2024

Possibly the same as #182 though that says it has been fixed...

@mmuetzel
Copy link
Contributor

Thank you for your report.

Do you still see this issue when you test with a nightly build that you could download from https://www.nic.funet.fi/pub/sci/physics/elmer/bin/windows/ ?

@Timmmm
Copy link
Author

Timmmm commented Sep 10, 2024

Yep.

@richb2k
Copy link
Contributor

richb2k commented Jan 8, 2025

PR #618 addresses most of the above issues. ToLower was added, so the file suffix can be either upper or lower case.

The binary stl file from Issue #566, bar.stl, now loads and is read, such as reading the proper number of facets, but then ElmerGui crashes during the meshing operation. The binary stl file from Issue #182, 02-cores.stl, loads and is read, and then is successfully meshed and displayed.

In other words, both binary files now load okay, but nglib has a problem meshing bar.stl and has no problem meshing 02-core.stl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants