ElmerGui, add reading of binary stl files. add toLower of file suffix, #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so opening of either *.stl or *.STL (lower or upper case) works.
show the current valid choices of input files.
|
Nice to have binary support for STL as well. You cannot always control how you get the files. |
|
Thanks for accepting both PRs, adding binary input for gmsh and stl files should help reduce some more errors. Could you take a look at the Windows builds, there hasn't been new Windows installer published to the ftp site in almost a month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so opening of either *.stl or *.STL (lower or upper case) works.
This PR is in response to issue #566 and issue #182.