Use unique Fortran module names #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some CMake generators (e.g., Ninja) require that Fortran modules have unique names. That is because these generators create `.mod` files for these modules in a common folder (`fmodules` in the build tree). Two files in `fem/tests` define Fortran modules named `ToroidCurrents`. Append numbers to these module names to work around the issue with some CMake generators (like Ninja). Fixes ElmerCSC#491.
The default generator of CMake on MSYS2 is Ninja. It performs better than the "MSYS Makefiles" generator on Windows (because `ninja` is a native application on Windows unlike `make`). Use it after ElmerCSC#491 is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CMake generators (e.g., Ninja) require that Fortran modules have unique names. That is because these generators create
.modfiles for these modules in a common folder (fmodulesin the build tree).Two files in
fem/testsdefine Fortran modules namedToroidCurrents. Append numbers to these module names to work around the issue with some CMake generators (like Ninja).Fixes #491.
Also, use Ninja on Windows now that it works.