Remove CMakeParseArguments.cmake and dependent modules.
#513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cmake_parse_argument` is implemented natively in CMake since version 3.5. Only previously, it was defined in a module. ElmerFEM already requires CMake 3.10 or newer. Remove that module and its dependencies because it is causing issues with VTK 9.1: ``` CMake Error at /usr/lib/x86_64-linux-gnu/cmake/vtk-9.1/vtkDetectLibraryType.cmake:23 (message): The `PATH` argument is required. Call Stack (most recent call first): /usr/lib/x86_64-linux-gnu/cmake/vtk-9.1/FindGLEW.cmake:19 (vtk_detect_library_type) /usr/lib/x86_64-linux-gnu/cmake/vtk-9.1/VTK-vtk-module-find-packages.cmake:256 (find_package) /usr/lib/x86_64-linux-gnu/cmake/vtk-9.1/vtk-config.cmake:150 (include) ElmerGUI/CMakeLists.txt:142 (FIND_PACKAGE) ```
|
It looks like this was reported previously by a different user on the VTK discourse forum: |
Use the default syntax to include the module `FindPackageHandleStandardArgs` now that there is no longer a conflict between the version of that module that is installed by CMake and the previously existing (old) copy of that module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake_parse_argumentis implemented natively in CMake since version 3.5. Only previously, it was defined in a module.ElmerFEM already requires CMake 3.10 or newer.
Remove that module and its dependencies because it is causing issues with VTK 9.1:
Also, use default syntax to include the module
FindPackageHandleStandardArgsnow that there is no longer a conflict between the module that is installed with CMake and the (old) copy that was bundled with ElmerFEM.