Avoid aliasing CMake import targets. #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a configuration issue with older versions of CMake. See: ElmerCSC#549 (comment) ``` CMake Error at CMakeLists.txt:217 (ADD_LIBRARY): ADD_LIBRARY cannot create ALIAS target "Elmer::MPI_Fortran" because target "MPI::MPI_Fortran" is imported but not globally visible. CMake Error at CMakeLists.txt:218 (ADD_LIBRARY): ADD_LIBRARY cannot create ALIAS target "Elmer::MPI_C" because target "MPI::MPI_C" is imported but not globally visible. CMake Error at CMakeLists.txt:219 (ADD_LIBRARY): ADD_LIBRARY cannot create ALIAS target "Elmer::MPI_CXX" because target "MPI::MPI_CXX" is imported but not globally visible. ```
|
I wonder if the failing launchpad builds are related. The recipes are here: |
|
Works for me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a configuration issue with older versions of CMake. See: #549 (comment)