Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QT compile-time warnings #990

Merged
merged 9 commits into from
Dec 4, 2024
Merged

Fix QT compile-time warnings #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
680a678
Fix QFlags initialization warning - use constructor
flipmcf Nov 18, 2024
66be34e
Fix QFlags initialization warning - use constructor
flipmcf Nov 18, 2024
7b056eb
#992
flipmcf Nov 21, 2024
96722c6
issue #992
flipmcf Nov 22, 2024
019d0bf
issue #992
flipmcf Nov 22, 2024
4c4c24b
rdtimeedit - #994
flipmcf Nov 25, 2024
4878686
QString::KeepEmptyParts -> Qt::KeepEmptyParts #993
flipmcf Nov 25, 2024
094e882
using asprintf now - #993
flipmcf Nov 26, 2024
517b85f
#993 exporting a ResultsReport Filter exercises this code
flipmcf Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/export_resultsrecon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,7 @@ bool RDReport::ExportResultsReport(const QString &filename,
*strm << QString::asprintf("%03d,",q->value(4).toInt());

// Title / Artist
*strm << QString().
sprintf("\"%-23s %-25s\",",
*strm << QString::asprintf("\"%-23s %-25s\",",
q->value(5).toString().left(23).toUtf8().constData(),
q->value(6).toString().left(25).toUtf8().constData());

Expand Down
2 changes: 1 addition & 1 deletion lib/rdbusybar.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class RDBusyBar : public QFrame
Q_OBJECT

public:
RDBusyBar(QWidget *parent=0,Qt::WindowFlags f=0);
RDBusyBar(QWidget *parent=0,Qt::WindowFlags f=Qt::WindowFlags());

public slots:
void activate(bool state);
Expand Down
2 changes: 1 addition & 1 deletion lib/rdbusydialog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class RDBusyDialog : public RDDialog
{
Q_OBJECT;
public:
RDBusyDialog(QWidget *parent=0,Qt::WindowFlags f=0);
RDBusyDialog(QWidget *parent=0,Qt::WindowFlags f=Qt::WindowFlags());
~RDBusyDialog();
QSize sizeHint() const;
void show(const QString &caption,const QString &label);
Expand Down
4 changes: 2 additions & 2 deletions lib/rddialog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ class RDDialog : public QDialog, public RDFontEngine
{
Q_OBJECT;
public:
RDDialog(QWidget *parent=0,Qt::WindowFlags f=0);
RDDialog(RDConfig *config,QWidget *parent=0,Qt::WindowFlags f=0);
RDDialog(QWidget *parent=0,Qt::WindowFlags f=Qt::WindowFlags());
RDDialog(RDConfig *config,QWidget *parent=0,Qt::WindowFlags f=Qt::WindowFlags());
};


Expand Down
4 changes: 2 additions & 2 deletions lib/rdframe.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ class RDFrame : public QFrame, public RDFontEngine
{
Q_OBJECT;
public:
RDFrame(QWidget *parent=0,Qt::WindowFlags f=0);
RDFrame(RDConfig *config,QWidget *parent=0,Qt::WindowFlags f=0);
RDFrame(QWidget *parent=0,Qt::WindowFlags f=Qt::WindowFlags());
RDFrame(RDConfig *config,QWidget *parent=0,Qt::WindowFlags f=Qt::WindowFlags());
};


Expand Down
4 changes: 2 additions & 2 deletions lib/rdmainwindow.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ class RDMainWindow : public RDWidget
{
Q_OBJECT;
public:
RDMainWindow(const QString &cmdname,Qt::WindowFlags f=0);
RDMainWindow(const QString &cmdname,RDConfig *c,Qt::WindowFlags f=0);
RDMainWindow(const QString &cmdname,Qt::WindowFlags f=Qt::WindowFlags());
RDMainWindow(const QString &cmdname,RDConfig *c,Qt::WindowFlags f=Qt::WindowFlags());
~RDMainWindow();
bool loadSettings(bool apply_geometry);
bool saveSettings() const;
Expand Down
4 changes: 2 additions & 2 deletions lib/rdtimeedit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ void RDTimeEdit::fixup(QString &input) const
// Don't allow higher precision than tenths of a second
//
if(d_show_tenths) {
QStringList f0=input.split(".",QString::KeepEmptyParts);
QStringList f0=input.split(".",Qt::KeepEmptyParts);
if(f0.size()==2) {
QStringList f1=f0.at(1).split(" ");
if(f1.at(0).length()>1) {
Expand Down Expand Up @@ -206,7 +206,7 @@ void RDTimeEdit::stepBy(int steps)
d_step_enabled=QTimeEdit::stepEnabled();
}
else {
d_step_enabled=0;
d_step_enabled=StepNone;
if(tenths>tenths_lo_limit) {
d_step_enabled=d_step_enabled|StepDownEnabled;
}
Expand Down
4 changes: 2 additions & 2 deletions lib/rdwidget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ class RDWidget : public QWidget, public RDFontEngine
{
Q_OBJECT;
public:
RDWidget(QWidget *parent=0,Qt::WindowFlags f=0);
RDWidget(RDConfig *config,QWidget *parent=0,Qt::WindowFlags f=0);
RDWidget(QWidget *parent=0,Qt::WindowFlags f=Qt::WindowFlags());
RDWidget(RDConfig *config,QWidget *parent=0,Qt::WindowFlags f=Qt::WindowFlags());
QPixmap backgroundPixmap() const;
void setBackgroundPixmap(const QPixmap &pix);

Expand Down
2 changes: 1 addition & 1 deletion rdcatch/vbox.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class VBox : public QWidget
{
Q_OBJECT
public:
VBox(QWidget *parent=0,Qt::WindowFlags f=0);
VBox(QWidget *parent=0,Qt::WindowFlags f=Qt::WindowFlags());
void addWidget(QWidget *widget);
void setSpacing(int space);

Expand Down
2 changes: 1 addition & 1 deletion rdlibrary/mainwindow.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class MainWindow : public RDMainWindow
{
Q_OBJECT;
public:
MainWindow(const QString &cmdname,RDConfig *c,Qt::WindowFlags f=0);
MainWindow(const QString &cmdname,RDConfig *c,Qt::WindowFlags f=Qt::WindowFlags());
bool showNoteBubbles() const;
void setShowNoteBubbles(bool state);
bool dragEnabled() const;
Expand Down