Added more logging #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice PR! I like the new changes and structure. This should be good to go IMO once we test. Although I think we're missing some metrics like ep_reward, ep_length and also we don't log the metadata in observation (could be a seperate PR maybe?) |
singhblom
force-pushed
the
msb/improve-logging
branch
2 times, most recently
from
f76ba30 to
8b146b5
Compare
|
@singhblom Is this still relevant? |
|
Yes, I think it can be added with some small amount of work. |
|
Poke @singhblom - there's some interesting things in here I'd like to get in w/ typing, interfaces etc. Better now than in another half a year ;-) |
singhblom
force-pushed
the
msb/improve-logging
branch
from
8b146b5 to
9c7922b
Compare
|
We decided to go in a different direction with the logging. |
JonasHedEng
pushed a commit
that referenced
this pull request
Jun 25, 2024
* add support for using local-emote. * add cheats doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't made sure the tests work yet but thought I'd drop this here so people can have a look. This addresses #27