Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gix to the latest version #27

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Conversation

Byron
Copy link
Contributor

@Byron Byron commented Sep 8, 2023

Please note that I have removed the max-performance-safe feature
which pushes the choice to the consumer of (any) library that uses
gix. It's also causing less C to be compiled by default.

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

An upgrade to the latest gix, which includes less dependencies now and compiles a little faster
because of it. It also avoids making decisions about performance (and the inclusion of C-crates)
by removing the max-performance-safe feature.

The motivation for this update is to get a new tame-index release for consumption in this PR
so that it can also use the latest gix version without duplication.

Related Issues

None

Please note that I have removed the `max-performance-safe` feature
which pushes the choice to the consumer of (any) library that uses
`gix`. It's also causing less C to be compiled by default.
@repi repi requested a review from Jake-Shadle September 8, 2023 20:39
Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Byron
Copy link
Contributor Author

Byron commented Sep 9, 2023

Oh, so the clippy lints are real - I thought this can't be as I have simplified and boxed errors rather than making them more complicated. I typically address these by ignoring the clippy lint, but maybe in this case, it's better to box? Please advise :).

Finally, you might be interested in a new line of conversation that will hopefully lead to a complete revamp of error handling as a mix between anyhow and thiserror: therror :D. Let's see if it happens, I surely hope so.

@Jake-Shadle Jake-Shadle merged commit 9ce30eb into EmbarkStudios:main Sep 11, 2023
@Jake-Shadle
Copy link
Member

But definitely interested to see what you can do for errors in future revisions, it is a bit of pain point with gix at the moment unless one goes the lazy anyhow route.

@Byron Byron deleted the gix-update branch September 11, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants