Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add formatter options for location (file + line number) and module_path #13

Conversation

zeeshanlakhani
Copy link
Contributor

@zeeshanlakhani zeeshanlakhani commented Feb 28, 2024

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

This PR adds options to the EventsFormatter for logging location (file + line number) and/or the module path. The options are false by default.

Tests are included.

@fredr
Copy link
Contributor

fredr commented Feb 29, 2024

Awesome, thank you! 💛

The location test fails on windows due to / vs \ in paths. maybe we could have different asserts based on target_os

@zeeshanlakhani
Copy link
Contributor Author

Awesome, thank you! 💛

The location test fails on windows due to / vs \ in paths. maybe we could have different asserts based on target_os

Yep, will fix/do.

@zeeshanlakhani zeeshanlakhani force-pushed the zl/options-for-location-and-module-path branch from 40ec2be to 563dc45 Compare February 29, 2024 12:04
@zeeshanlakhani
Copy link
Contributor Author

@fredr updated. Hopefully, now passes on CI :). I also updated the line checking to be more general.

@fredr
Copy link
Contributor

fredr commented Feb 29, 2024

Nice, thank you! I'll merge this now, and will make a release of it later today or tomorrow!

@fredr fredr merged commit d079cac into EmbarkStudios:main Feb 29, 2024
6 checks passed
@zeeshanlakhani
Copy link
Contributor Author

Nice, thank you! I'll merge this now, and will make a release of it later today or tomorrow!

Perfect. Sounds good on the release timing!

@zeeshanlakhani zeeshanlakhani deleted the zl/options-for-location-and-module-path branch February 29, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants