Add support for disabling ansi color when the feature is enabled #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredr
force-pushed
the
fredr/disable-ansi-color
branch
from
08351fe to
8e07471
Compare
|
Thanks! Just tested this, does the right thing out of the box! Used a |
Co-authored-by: Björn Westlin <[email protected]>
|
Thanks! Can you tag a release with this? |
flokli
added a commit
to flokli/mycelium
that referenced
this pull request
Aug 5, 2024
This will cause to be outputted with color in case the output is a terminal, but will refrain from doing so if it's run by a service manager. Follow-up to threefoldtech#316, unblocked by EmbarkStudios/tracing-logfmt#16
LeeSmet
pushed a commit
to threefoldtech/mycelium
that referenced
this pull request
Aug 19, 2024
This will cause to be outputted with color in case the output is a terminal, but will refrain from doing so if it's run by a service manager. Follow-up to #316, unblocked by EmbarkStudios/tracing-logfmt#16
maximevanhees
pushed a commit
to threefoldtech/mycelium
that referenced
this pull request
Aug 21, 2024
This will cause to be outputted with color in case the output is a terminal, but will refrain from doing so if it's run by a service manager. Follow-up to #316, unblocked by EmbarkStudios/tracing-logfmt#16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
Adds support for disabling ansi colors (via
with_ansi_color) when theansi_logsfeature is enabled. It also defaults to only emitting colors if stdout is a terminal.I also added
with_timestamp, so it is possible to disable timestamps, mainly to make it easier to write tests.Related Issues
Fixes #15