Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed Screen Visual Polish #270

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Feed Screen Visual Polish #270

merged 4 commits into from
Jan 17, 2025

Conversation

Rahkeen
Copy link
Collaborator

@Rahkeen Rahkeen commented Jan 10, 2025

Updating Look + Feel Related to Feed Screen

Copy link
Collaborator Author

Rahkeen commented Jan 10, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Rahkeen Rahkeen changed the title New Navigation Bar Style for Feed Screen Feed Screen Visual Polish Jan 10, 2025
@Rahkeen Rahkeen marked this pull request as ready for review January 10, 2025 01:13
Copy link

emerge-tools bot commented Jan 10, 2025

📸 Snapshot Test

46 modified, 10 added, 3 removed, 25 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
HackerNews Swift-Snapshot-Testing
com.emerge.hn.Hacker-News.swiftsnapshottesting
0 0 18 0 0 0 ✅ Approved
HackerNews
com.emergetools.hackernews.snapshots
10 3 28 0 25 0 ✅ Approved

🛸 Powered by Emerge Tools

Copy link

emerge-tools bot commented Jan 12, 2025

2 builds increased size, 1 build had no size change

Name Version Download Change Install Change Approval
⚠️ HackerNews
com.emerge.hn.Hacker-News
3.4 (1) 7.2 MB ⬆️ 569.5 kB (8.58%) 9.6 MB ⬆️ 1.2 MB (15.06%) ✅ Approved
⚠️ HackerNews
com.emergetools.hackernews.snapshots
3.4 (1) 7.9 MB ⬆️ 583.9 kB (7.99%) 13.1 MB ⬆️ 1.3 MB (11.35%) N/A
HackerNews Swift-Snapshot-Testing
com.emerge.hn.Hacker-News.swiftsnapshottesting
() 0 B - 0 B - N/A

HackerNews 3.4 (1)
com.emerge.hn.Hacker-News

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 1.2 MB (15.06%)
Total download size change: ⬆️ 569.5 kB (8.58%)

Largest size changes

Item Install Size Change
📝 unbounded.ttf ⬆️ 778.2 kB
📝 ibm_plex_sans_medium.ttf ⬆️ 180.2 kB
📝 ibm_plex_sans_bold.ttf ⬆️ 139.3 kB
📝 ibm_plex_sans_regular.ttf ⬆️ 135.2 kB
📝 HackerNews.FeedScreen.body ⬆️ 6.5 kB
View Treemap

Image of diff

HackerNews 3.4 (1)
com.emergetools.hackernews.snapshots

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 1.3 MB (11.35%)
Total download size change: ⬆️ 583.9 kB (7.99%)

Largest size changes

Item Install Size Change
📝 unbounded.ttf ⬆️ 778.2 kB
📝 ibm_plex_sans_medium.ttf ⬆️ 180.2 kB
📝 ibm_plex_sans_bold.ttf ⬆️ 139.3 kB
📝 ibm_plex_sans_regular.ttf ⬆️ 135.2 kB
DYLD.String Table ⬆️ 47.5 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

@Rahkeen Rahkeen force-pushed the home-screen-polish-pass branch from 2ce162f to 20558d1 Compare January 15, 2025 04:32
@Rahkeen Rahkeen force-pushed the home-screen-polish-pass branch from 20558d1 to eb19e79 Compare January 17, 2025 05:31
@Rahkeen Rahkeen merged commit cafe655 into main Jan 17, 2025
6 of 7 checks passed
@Rahkeen Rahkeen deleted the home-screen-polish-pass branch January 17, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant