Switched to dune #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I approve the concept. But this single change seems to mix fixes with the switch to dune? Perhaps it is worth splitting code changes from the buildsystem change. |
|
I'll have a look at it… |
This reverts commit 0f802ce.
"stdlib-shims" dependency is added to assure backward compatibility for older compilers.
The examples compile with: `dune build profile=release`
|
This PR should be merged. |
|
@olafhering what is the lower bound version of ocaml that you want to stay compatible with? |
|
4.14 is fine with me, this is what will be included in |
|
Superseded by #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.