Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(revamp): layout fixes #3311

Merged
merged 5 commits into from
Oct 29, 2023
Merged

fix(revamp): layout fixes #3311

merged 5 commits into from
Oct 29, 2023

Conversation

neuodev
Copy link
Contributor

@neuodev neuodev commented Oct 14, 2023

  • Add the correct eye icon for all password inputs
  • Fix old modern dialog
  • Fix crowded inputs

@neuodev neuodev requested a review from Nebyt October 14, 2023 06:47
@neuodev
Copy link
Contributor Author

neuodev commented Oct 14, 2023

[autoscirpt] Jira Ticket: The eye icon in the password field is different from the design

@neuodev neuodev marked this pull request as ready for review October 17, 2023 09:14
@neuodev neuodev self-assigned this Oct 17, 2023
@vsubhuman vsubhuman added this to the 5.0.0 milestone Oct 27, 2023
@vsubhuman vsubhuman changed the base branch from develop to release/5.0 October 27, 2023 16:58
@vsubhuman vsubhuman mentioned this pull request Oct 29, 2023
Merged
43 tasks
vsubhuman
vsubhuman reviewed Oct 29, 2023
View reviewed changes
Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vsubhuman vsubhuman merged commit 198f10f into release/5.0 Oct 29, 2023
6 of 12 checks passed
@vsubhuman vsubhuman deleted the Ahmed/YOEXT-767/eye-icon branch October 29, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsubhuman vsubhuman vsubhuman approved these changes

@Nebyt Nebyt Nebyt approved these changes

Assignees

@neuodev neuodev

Labels
None yet
Projects
None yet
Milestone
5.0.0 (revamp, analytics)
Development

Successfully merging this pull request may close these issues.
3 participants
@neuodev @vsubhuman @Nebyt