Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connector init error fix #3332

Merged
merged 5 commits into from
Oct 27, 2023
Merged

connector init error fix #3332

merged 5 commits into from
Oct 27, 2023

Conversation

vsubhuman
Copy link
Contributor

  1. A missing function in rustLoaderForBackground fixed
  2. An incorrect passing of a function into setRuntime fixed
  3. Missing fields in defaultNetworkConfig fixed
  4. Incorrect handling of auxiliaryData.metadata fixed

@vsubhuman
fixed missing function in rust-loader-for-background, plus incorrect …
fe6f102 
…function pass, plus insufficient protocol params, plus incorrect metadata handling
@vsubhuman
Merge branch 'fix/YOEXT-758/connector-rpc-error-message' into fix/YOE…
2c9382b 
…XT-788/connector-init-error
@vsubhuman
flow fix
81708f8
@vsubhuman vsubhuman added this to the 4.23.0 milestone Oct 26, 2023
@vsubhuman vsubhuman requested review from yushih and Nebyt October 26, 2023 20:44
@neuodev
Copy link
Contributor

neuodev commented Oct 26, 2023

[autoscirpt] Jira Ticket: The error is received when sending a request to the dapp-connector

vsubhuman
vsubhuman commented Oct 26, 2023
View reviewed changes
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman vsubhuman mentioned this pull request Oct 26, 2023
Merged
24 tasks
@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vsubhuman vsubhuman merged commit 505e9fe into release/4.23 Oct 27, 2023
6 of 12 checks passed
@vsubhuman vsubhuman deleted the fix/YOEXT-788/connector-init-error branch October 27, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nebyt Nebyt Nebyt approved these changes

@yushih yushih Awaiting requested review from yushih

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vsubhuman @neuodev @Nebyt