Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(revamp): address all UAT revamp issue pt.2 #3336

Merged
merged 18 commits into from
Nov 6, 2023
Merged

Conversation

@neuodev
Copy link
Contributor Author

neuodev commented Oct 31, 2023

[autoscript] ⚠️ fix/uat-revamp-2 doesn't full our branch naming convention.
Should follow <tag>/<jira-ticket-id>/<short-name>

Details
  • <tag>: fix, feat, chore, refactor, test, ...
  • <jira-ticket-id>: The issue ID of JIRA all capital letters
  • <short-name>: A short and descriptive name for the branch

Base automatically changed from fix/uat-revamp to release/5.0 November 1, 2023 19:35
@vsubhuman vsubhuman added this to the 5.0.0 (revamp, analytics) milestone Nov 1, 2023
@neuodev neuodev self-assigned this Nov 5, 2023
@neuodev neuodev marked this pull request as ready for review November 6, 2023 10:51
@neuodev neuodev requested a review from vsubhuman November 6, 2023 10:54
vsubhuman
vsubhuman previously approved these changes Nov 6, 2023
@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition C Reliability Rating on New Code (is worse than A)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

@vsubhuman vsubhuman merged commit dfe00bb into release/5.0 Nov 6, 2023
5 of 12 checks passed
@vsubhuman vsubhuman deleted the fix/uat-revamp-2 branch November 6, 2023 13:48
@vsubhuman vsubhuman mentioned this pull request Nov 6, 2023
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants