fix(ds): revamp modal dialog fixes #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed token and nft dialog styles
|
[autoscirpt] Jira Ticket: UAT. General. Modals. Difference from the design. |
…Emurgo/yoroi-frontend into fix/YOEXT-836/revamp-modal-dialog-fixes
Nebyt
previously approved these changes
Nov 17, 2023
|
SonarQube Quality Gate
|
Nebyt
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixed a lot of styles and added scrollable borders
Note: Since the scrollable content can be any element inside the modal content, I added a new prop to pass the class of the possible content that can be scrollable, the modal component checks at render if it is the case or not and adds the proper state & styles to the element. Below we have an example.
Add Token modal has a different scrollable element👇🏽
And AddNFT modal too👇🏽
