Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing theme legacy #3688

Merged
merged 21 commits into from
Dec 24, 2024

Conversation

vsubhuman
Copy link
Contributor

@vsubhuman vsubhuman commented Oct 13, 2024

@vsubhuman vsubhuman requested review from Nebyt and SorinC6 October 13, 2024 13:11
@vsubhuman vsubhuman changed the title removed legacy isModernTheme and isClassicTheme removing theme legacy Oct 13, 2024
@vsubhuman vsubhuman marked this pull request as ready for review October 13, 2024 20:54
@vsubhuman vsubhuman changed the base branch from develop to ruslan/delete-unused October 13, 2024 20:54
@vsubhuman vsubhuman requested a review from nistadev October 14, 2024 06:02
nistadev
nistadev previously approved these changes Oct 15, 2024
Copy link
Contributor

@nistadev nistadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!! 🚀

Base automatically changed from ruslan/delete-unused to develop October 26, 2024 19:19
@vsubhuman vsubhuman dismissed nistadev’s stale review October 26, 2024 19:19

The base branch was changed.

…removing-legacy-theme-functions

# Conflicts:
#	packages/yoroi-extension/app/components/layout/TopBarLayout.js
#	packages/yoroi-extension/app/components/settings/categories/SupportSettings.js
#	packages/yoroi-extension/app/components/settings/categories/general-setting/ExplorerSettings.js
#	packages/yoroi-extension/app/components/settings/categories/general-setting/GeneralSettings.js
#	packages/yoroi-extension/app/components/settings/categories/general-setting/UnitOfAccountSettings.js
#	packages/yoroi-extension/app/components/settings/categories/general-setting/UriSettingsBlock.js
#	packages/yoroi-extension/app/components/wallet/hwConnect/ledger/CheckDialog.js
#	packages/yoroi-extension/app/components/wallet/hwConnect/ledger/ConnectDialog.js
#	packages/yoroi-extension/app/components/wallet/receive/VerifyAddressDialog.js
#	packages/yoroi-extension/app/components/wallet/send/WalletSendFormRevamp.js
#	packages/yoroi-extension/app/components/wallet/settings/RemoveWallet.js
#	packages/yoroi-extension/app/components/wallet/settings/ResyncBlock.js
#	packages/yoroi-extension/app/components/wallet/settings/WalletNameSetting.js
#	packages/yoroi-extension/app/components/widgets/DangerousActionDialog.js
#	packages/yoroi-extension/app/components/widgets/Dialog.js
#	packages/yoroi-extension/app/containers/settings/categories/BlockchainSettingsPage.js
#	packages/yoroi-extension/app/containers/settings/categories/GeneralSettingsPage.js
#	packages/yoroi-extension/app/containers/settings/categories/RemoveWalletDialogContainer.js
#	packages/yoroi-extension/app/containers/settings/categories/WalletSettingsPage.js
#	packages/yoroi-extension/app/containers/transfer/Transfer.js
#	packages/yoroi-extension/app/containers/wallet/WalletSendPage.js
#	packages/yoroi-extension/app/containers/wallet/dialogs/ChangeWalletPasswordDialogContainer.js
#	packages/yoroi-extension/app/containers/wallet/staking/StakingPageContent.js
#	packages/yoroi-extension/app/stores/ada/AdaDelegationTransactionStore.js
#	packages/yoroi-extension/app/stores/stateless/sidebarCategories.js
#	packages/yoroi-extension/app/stores/toplevel/ProfileStore.js
@vsubhuman vsubhuman added this to the 5.5.0 milestone Dec 17, 2024
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

…removing-legacy-theme-functions

# Conflicts:
#	packages/yoroi-extension/app/components/profile/complexity-level/ComplexityLevelForm.js
#	packages/yoroi-extension/app/components/wallet/hwConnect/trezor/CheckDialog.js
#	packages/yoroi-extension/app/components/wallet/hwConnect/trezor/ConnectDialog.js
@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vsubhuman vsubhuman merged commit 5ce89c2 into develop Dec 24, 2024
8 of 9 checks passed
@vsubhuman vsubhuman deleted the ruslan/YOEXT-1433/removing-legacy-theme-functions branch December 24, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants