Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box shadows #3798

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Box shadows #3798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be995e5
new box shadow
Nebyt Dec 27, 2024
cc007a1
changed box shadow on Select component
Nebyt Dec 27, 2024
8404ff3
applied different shadow on autoselect
Nebyt Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/yoroi-extension/app/components/common/Select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ type Props = {|
labelProps?: Object,
helperText?: string,
options: Array<Object>,
maxHeight?: string,
|};

function Select({
Expand All @@ -28,6 +29,7 @@ function Select({
shrink,
disabled,
labelProps,
maxHeight,
...props
}: Props): Node {
const theme = useTheme();
Expand All @@ -53,9 +55,6 @@ function Select({
onChange={e => onChange(e.target.value)}
onClose={handleClose}
onOpen={handleOpen}
sx={{
boxShadow: open ? theme.palette.ds.light_shadow_dropdown_menu : 'unset',
}}
MenuProps={{
anchorOrigin: {
vertical: 'bottom',
Expand All @@ -65,6 +64,13 @@ function Select({
vertical: 'top',
horizontal: 'left',
},
sx: {
'& .MuiMenu-paper': {
maxHeight: maxHeight != null ? maxHeight : '500px',
borderRadius: '8px',
boxShadow: open ? theme.palette.ds.light_shadow_dropdown_menu : 'unset',
},
},
...(menuProps !== null && menuProps),
}}
{...props}
Expand Down
2 changes: 1 addition & 1 deletion packages/yoroi-extension/app/components/common/autocomplete/Autocomplete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ const ULList = styled(Box)(({ theme, isOpen }) => ({
outline: '0',
transition: 'opacity .1s ease',
borderRadius: 0,
boxShadow: isOpen ? theme.palette.ds.light_shadow_dropdown_menu : 'unset',
boxShadow: isOpen ? theme.palette.ds.light_shadow_dropdown_words : 'unset',
}));

const InputWrapper = styled(Box)(
Expand Down
8 changes: 1 addition & 7 deletions ...roi-extension/app/components/settings/categories/general-setting/UnitOfAccountSettings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,13 +169,7 @@ export default class UnitOfAccountSettings extends Component<Props> {
{...coinPriceCurrencyId.bind()}
onChange={this.props.onSelect}
value={currentValue}
menuProps={{
sx: {
'& .MuiMenu-paper': {
maxHeight: '280px',
},
},
}}
maxHeight='280px'
renderValue={value => (
<Typography component="div"
variant="body1"
Expand Down
3 changes: 2 additions & 1 deletion packages/yoroi-extension/app/styles/themes/base-palettes/dark-palette.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,6 @@ export const darkPalette = {
bg_gradient_3: 'linear-gradient(23deg, #2E4BB0 15.04%, #2B3E7D 84.96%)',
special_web_overlay: 'rgba(31, 35, 46, 0.80)',
special_web_bg_sidebar: 'rgba(0, 0, 0, 0.16)',
light_shadow_dropdown_menu: `0px 4px 20px 0px #0000007A`, // dropdown shadow
light_shadow_dropdown_words: `0px 3px 10px rgba(24, 26, 30, 0.08)`, // dropdown shadow
light_shadow_dropdown_menu: `0px 4px 10px rgba(24, 26, 30, 0.16)`,
};
3 changes: 2 additions & 1 deletion packages/yoroi-extension/app/styles/themes/base-palettes/light-palette.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,5 +56,6 @@ export const lightPalette = {
bg_gradient_3: 'linear-gradient(30deg, #244ABF 0%, #4760FF 100%)',
special_web_overlay: 'rgba(31, 35, 46, 0.80)',
special_web_bg_sidebar: '#1F232ECC',
light_shadow_dropdown_menu: '0px 4px 10px 0px #181A1E29',
light_shadow_dropdown_words: `0px 3px 10px rgba(24, 26, 30, 0.08)`,
light_shadow_dropdown_menu: `0px 4px 10px rgba(24, 26, 30, 0.16)`,
};
1 change: 1 addition & 0 deletions packages/yoroi-extension/app/styles/themes/types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,5 +77,6 @@ export type DSColorPalette = {|
web_sidebar_item_active_bg: string,
mobile_overlay: string,
mobile_bg_blur: string,
light_shadow_dropdown_words: string,
light_shadow_dropdown_menu: string,
|};
Loading