Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(settings): wallet settings revamp #2672

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

banklesss
Copy link
Contributor

@banklesss banklesss commented Sep 11, 2023

Related to YOMO-747

Simulator.Screen.Recording.-.iPhone.14.Pro.Max.-.2023-09-11.at.09.38.52.mp4

},
tabBarActiveTintColor: COLORS.SHELLEY_BLUE,
tabBarInactiveTintColor: COLORS.NOT_SELECTED_TAB_TEXT,
})}
style={{marginHorizontal: 16}}
Copy link
Contributor Author

@banklesss banklesss Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid this:

Simulator Screenshot - iPhone 14 Pro Max - 2023-09-11 at 09 41 11

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ths screenshoot above is done with paddingHorizontal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding style={{marginHorizontal: 16}} we can have tabs with padding

@stackchain stackchain added this to the 5.0.0 milestone Sep 11, 2023
@stackchain stackchain merged commit c656b39 into develop Sep 11, 2023
2 checks passed
@stackchain stackchain deleted the feature/wallet-settings-revamp branch September 11, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants