Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(settings): improvements #2676

Merged
merged 12 commits into from
Sep 11, 2023
Merged

chore(settings): improvements #2676

merged 12 commits into from
Sep 11, 2023

Conversation

banklesss
Copy link
Contributor

👀

@banklesss banklesss self-assigned this Sep 11, 2023
@banklesss banklesss added chore and removed feature labels Sep 11, 2023
@banklesss banklesss marked this pull request as draft September 11, 2023 10:51
@banklesss
Copy link
Contributor Author

fixing the margin issue

@stackchain stackchain added this to the 5.0.0 milestone Sep 11, 2023
@michaeljscript
Copy link
Collaborator

Hello @banklesss , is this still a draft of ready for a review?

@banklesss
Copy link
Contributor Author

Hello @banklesss , is this still a draft of ready for a review?

What I'm fixing isn't related to anything done here so feel free to suggest.

@banklesss banklesss force-pushed the feature/wallet-settings-revamp branch from 4281595 to 3582aed Compare September 11, 2023 15:00
@banklesss banklesss marked this pull request as ready for review September 11, 2023 15:05
stackchain
stackchain reviewed Sep 11, 2023
View reviewed changes
Copy link
Member

@stackchain stackchain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor CRs, lgtm

apps/wallet-mobile/src/features/Settings/WalletSettings/WalletSettingsScreen.tsx Outdated Show resolved Hide resolved
@banklesss banklesss force-pushed the feature/wallet-settings-revamp branch from 6ade6e5 to 5df3ac2 Compare September 11, 2023 15:28
@stackchain stackchain merged commit 778ceed into develop Sep 11, 2023
@stackchain stackchain deleted the feature/wallet-settings-revamp branch September 11, 2023 23:09
@stackchain stackchain mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljscript michaeljscript michaeljscript approved these changes

@jorbuedo jorbuedo Awaiting requested review from jorbuedo

@SorinC6 SorinC6 Awaiting requested review from SorinC6

@stackchain stackchain Awaiting requested review from stackchain

Assignees

@banklesss banklesss

Labels
chore
Projects
None yet
Milestone
4.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@banklesss @michaeljscript @stackchain