-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update limit price on refresh #2723
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SorinC6 @stackchain pretty sure #2722 is wrong
Is not ok. Formatted value can't be passed to asQuantity.
createOrder.limitPrice is not directly assignable to the input And
None of that should be modified from here. The pool change is already done on createOrder, and again limitPriceChanged can't receive that. |
ad05ded
to
126efb2
Compare
@stackchain now it should work |
Passing tests, the ultimate frontier |
fixes https://emurgo.atlassian.net/browse/YOMO-811 as well |
https://emurgo.atlassian.net/browse/YOMO-799?focusedCommentId=18108
https://emurgo.atlassian.net/browse/YOMO-811