Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typos and upd expandable card api #2727

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: typos and upd expandable card api #2727

merged 1 commit into from
Sep 27, 2023

Conversation

stackchain
Copy link
Member

@stackchain stackchain commented Sep 27, 2023 •
edited
Loading

  • fix typo: arow (leaking impl)
  • fix fees to Fees according the design
  • refactor normalized the api terms info + expanded for the ExpandedCard component

@stackchain stackchain added this to the 5.0.0 milestone Sep 27, 2023
@stackchain stackchain requested a review from SorinC6 September 27, 2023 20:37
@github-actions github-actions bot added the fix label Sep 27, 2023
@stackchain stackchain self-assigned this Sep 27, 2023
@stackchain stackchain marked this pull request as ready for review September 27, 2023 20:37
@stackchain stackchain merged commit d6fe8bd into develop Sep 27, 2023
@stackchain stackchain deleted the fix/typos-api-expandable branch September 27, 2023 20:48
@stackchain stackchain mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banklesss banklesss banklesss approved these changes

@SorinC6 SorinC6 Awaiting requested review from SorinC6

@michaeljscript michaeljscript Awaiting requested review from michaeljscript

Assignees

@stackchain stackchain

Labels
fix
Projects
None yet
Milestone
4.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stackchain @banklesss