chore: impr ffee #2738
Merged
chore: impr ffee #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackchain
commented
Oct 2, 2023
|
|
||
| export const milkTokenId = { | ||
| mainnet: '8a1cfae21368b8bebbbed9800fec304e95cce39a2a57dc35e2e3ebaa.4d494c4b', | ||
| preprod: '8a1cfae21368b8bebbbed9800fec304e95cce39a2a57dc35e2e3ebaa.4d494c4b', |
jorbuedo
approved these changes
Oct 2, 2023
| @@ -30,8 +30,8 @@ export const getBuyAmount = ( | |||
| return { | |||
| tokenId, | |||
| quantity: asQuantity( | |||
| BigNumber(sell.quantity) | |||
| .dividedToIntegerBy(BigNumber(limit)) | |||
| new BigNumber(sell.quantity) | |||
There was a problem hiding this comment.
From their docs, new is optional
x = new BigNumber(123.4567) // '123.4567'
// 'new' is optional
y = BigNumber(x) // '123.4567'
But we can add them if you like them
There was a problem hiding this comment.
TS complains after BN 9.1
There was a problem hiding this comment.
Uh, ok, I hadn't noticed anything but probably didn't do any install yet since 9.1 4 days ago
| sellAmount: Balance.Amount | ||
| buyAmount: Balance.Amount | ||
| milkBalance: Balance.Quantity | ||
| sellInPrimaryTokenValue: Balance.Amount |
There was a problem hiding this comment.
Do we get these from finding a pool between sell token and ada?
There was a problem hiding this comment.
these are received from the order + some metadata that it still don't have such as the sell/buy value in primary when they are not the primary. iUSD/DJED -> iUSD/ADA + DJED/ADA (based on what's selling)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.