fix: Swap - confirm with password error reset

apps/wallet-mobile/src/features/Swap/common/ConfirmWithSpendingPassword/ConfirmWithSpendingPassword.tsx

@@ -7,13 +7,19 @@ import {COLORS} from '../../../../theme'
 import {WrongPassword} from '../../../../yoroi-wallets/cardano/errors'
 import {useStrings} from '../../common/strings'
 
+export type ErrorData = {
+  errorMessage: string
+  errorLogs?: unknown
+}
+
 type Props = {
   onSubmit?: (spendingPassword: string) => void
   isLoading?: boolean
   error?: Error
+  onPasswordChange?: () => void
 }
 
-export const ConfirmWithSpendingPassword = ({onSubmit, isLoading, error}: Props) => {
+export const ConfirmWithSpendingPassword = ({onSubmit, isLoading, error, onPasswordChange}: Props) => {
   const spendingPasswordRef = React.useRef<RNTextInput>(null)
   const [spendingPassword, setSpendingPassword] = React.useState(
     features.prefillWalletInfo ? debugWalletInfo.PASSWORD : '',
@@ -30,7 +36,10 @@ export const ConfirmWithSpendingPassword = ({onSubmit, isLoading, error}: Props)
         enablesReturnKeyAutomatically
         placeholder={strings.spendingPassword}
         value={spendingPassword}
-        onChangeText={setSpendingPassword}
+        onChangeText={(text) => {
+          setSpendingPassword(text)
+          onPasswordChange && onPasswordChange()
+        }}
         autoComplete="off"
       />
 
@@ -44,7 +53,13 @@ export const ConfirmWithSpendingPassword = ({onSubmit, isLoading, error}: Props)
 
       <Spacer fill />
 
-      <Button testID="swapButton" shelleyTheme title={strings.sign} onPress={() => onSubmit?.(spendingPassword)} />
+      <Button
+        testID="swapButton"
+        shelleyTheme
+        title={strings.sign}
+        onPress={() => onSubmit?.(spendingPassword)}
+        disabled={spendingPassword.length === 0}
+      />
 
       {isLoading && (
         <View style={styles.loading}>

apps/wallet-mobile/src/features/Swap/common/useSwapTx.ts

@@ -23,7 +23,6 @@ export const useSwapTx = (options?: UseMutationOptions<YoroiUnsignedTx, Error, {
             buyQuantity: orderData.amounts.buy.quantity,
             feeTokenId: pool?.deposit.tokenId,
             feeTokenId: pool?.deposit.tokenId,
-
           }),
         ),
       },

apps/wallet-mobile/src/features/Swap/useCases/ConfirmTxScreen/ConfirmTxWithPassword.tsx

@@ -5,13 +5,9 @@ import {YoroiWallet} from '../../../../yoroi-wallets/cardano/types'
 import {useSignWithPasswordAndSubmitTx} from '../../../../yoroi-wallets/hooks'
 import {YoroiUnsignedTx} from '../../../../yoroi-wallets/types'
 import {ConfirmWithSpendingPassword} from '../../common/ConfirmWithSpendingPassword'
+import {ErrorData} from '../../common/ConfirmWithSpendingPassword/ConfirmWithSpendingPassword'
 import {useStrings} from '../../common/strings'
 
-type ErrorData = {
-  errorMessage: string
-  errorLogs?: unknown
-}
-
 type Props = {
   wallet: YoroiWallet
   unsignedTx: YoroiUnsignedTx
@@ -64,6 +60,7 @@ export const ConfirmTxWithPassword = ({wallet, onSuccess, unsignedTx}: Props) =>
       onSubmit={onConfirm}
       isLoading={isLoading}
       error={errorData.errorMessage.length > 0 ? new Error(errorData.errorMessage) : undefined}
+      onPasswordChange={() => setErrorData({errorMessage: '', errorLogs: ''})}
     />
   )
 }

packages/swap/src/adapters/openswap-api/api.test.ts

@@ -346,4 +346,4 @@ describe('swapApiMaker', () => {
       expect(mockOpenSwapApi.getPrice).toHaveBeenCalledTimes(1)
     })
   })
-})
+})