refactor(swap): modals #2746
Merged
refactor(swap): modals #2746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banklesss
requested review from
michaeljscript,
stackchain,
SorinC6 and
jorbuedo
and removed request for
stackchain
banklesss
commented
Oct 9, 2023
| @@ -35,6 +52,9 @@ const WalletTabNavigator = () => { | |||
| tabBarLabelStyle: {fontSize: 11}, | |||
| tabBarActiveTintColor: theme.COLORS.NAVIGATION_ACTIVE, | |||
| tabBarInactiveTintColor: theme.COLORS.NAVIGATION_INACTIVE, | |||
| tabBarStyle: { | |||
| display: keyboardStatus ? 'none' : undefined, | |||
There was a problem hiding this comment.
Alternate fix for https://emurgo.atlassian.net/browse/YOMO-549
jorbuedo
approved these changes
Oct 10, 2023
apps/wallet-mobile/src/features/Swap/useCases/ConfirmTxScreen/ConfirmTxScreen.tsx
Show resolved
Hide resolved
michaeljscript
approved these changes
Oct 10, 2023
|
Working to solve an issue |
banklesss
force-pushed
the
refactor/bottom-modals
branch
from
d7d155a to
16e43ac
Compare
issue fixed |
michaeljscript
approved these changes
Oct 10, 2023
SorinC6
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
./gradlew cleanin theandroidfolderwindowSoftInputModefromadjustPantoadjustResizebecause it was impossible to fix the modals before this. This config was applied time ago to fix this. A alternate solution has been applied.