Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(swap): yoroi entry for non ada tokens #2773

Merged
merged 1 commit into from
Oct 15, 2023
Merged

fix(swap): yoroi entry for non ada tokens #2773

merged 1 commit into from
Oct 15, 2023

Conversation

SorinC6
Copy link
Contributor

@SorinC6 SorinC6 commented Oct 13, 2023 •
edited
Loading

⚠️ Tests for the helper to be added

@SorinC6 SorinC6 marked this pull request as draft October 13, 2023 13:43
@SorinC6 SorinC6 changed the title swap: fix yoroi entry for non ada tokens fix(swap): yoroi entry for non ada tokens Oct 13, 2023
stackchain
stackchain reviewed Oct 13, 2023
View reviewed changes
apps/wallet-mobile/src/features/Swap/common/helpers.ts
createOrder.amounts.sell.quantity,
])
} else {
amountEntry[wallet.primaryTokenInfo.id] = Quantities.sum([
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@stackchain stackchain added this to the 5.0.0 milestone Oct 13, 2023
@stackchain
Copy link
Member

@SorinC6 merging the fix.

@stackchain stackchain marked this pull request as ready for review October 15, 2023 10:18
@stackchain stackchain merged commit a4aae09 into develop Oct 15, 2023
3 checks passed
@stackchain stackchain deleted the fix-entry branch October 15, 2023 10:19
@stackchain stackchain mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stackchain stackchain stackchain left review comments

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
4.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SorinC6 @stackchain