New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(swap): Metadata labels #2782

Merged

stackchain merged 8 commits into develop from fix/metadata-labels

Oct 17, 2023

Contributor

SorinC6 commented Oct 16, 2023

No description provided.

github-actions bot added the fix label

SorinC6 requested a review from stackchain

October 16, 2023 09:53

jorbuedo approved these changes

View reviewed changes

stackchain reviewed

View reviewed changes

apps/wallet-mobile/src/features/Swap/common/helpers.ts Outdated Show resolved Hide resolved

stackchain reviewed

View reviewed changes

apps/wallet-mobile/src/features/Swap/common/helpers.ts Outdated Show resolved Hide resolved

stackchain reviewed

View reviewed changes

apps/wallet-mobile/src/features/Swap/common/helpers.ts Outdated Show resolved Hide resolved

stackchain reviewed

View reviewed changes

apps/wallet-mobile/src/features/Swap/common/helpers.ts Outdated Show resolved Hide resolved

stackchain reviewed

View reviewed changes

apps/wallet-mobile/src/features/Swap/common/helpers.ts Outdated Show resolved Hide resolved

stackchain reviewed

View reviewed changes

apps/wallet-mobile/src/features/Swap/common/helpers.ts Outdated Show resolved Hide resolved

stackchain reviewed

View reviewed changes

apps/wallet-mobile/src/features/Swap/common/helpers.ts Outdated Show resolved Hide resolved

stackchain reviewed

View reviewed changes

apps/wallet-mobile/src/features/Swap/useCases/StartSwapScreen/ListOrders/CompletedOrders.tsx Outdated Show resolved Hide resolved

stackchain reviewed

View reviewed changes

apps/wallet-mobile/src/features/Swap/useCases/StartSwapScreen/ListOrders/CompletedOrders.tsx Outdated Show resolved Hide resolved

stackchain reviewed

View reviewed changes

apps/wallet-mobile/src/yoroi-wallets/cardano/processTransactions/processTransactions.ts Outdated Show resolved Hide resolved

stackchain reviewed

View reviewed changes

Member

stackchain left a comment

renaming for consistence (the metadata is included in the open order only right?)

stackchain added this to the 5.0.0 milestone

stackchain changed the title ~~Fix/metadata labels~~ fix: Metadata labels

Contributor Author

SorinC6 commented Oct 16, 2023

renaming for consistence (the metadata is included in the open order only right?)

for open order we use the api to get the open transactions, just for the complete orders we scrap the transaction and make use of the metadata

SorinC6 changed the title ~~fix: Metadata labels~~ fix(swap): Metadata labels

stackchain reviewed

View reviewed changes

apps/wallet-mobile/src/features/Swap/common/helpers.ts Outdated Show resolved Hide resolved

stackchain reviewed

View reviewed changes

apps/wallet-mobile/src/yoroi-wallets/types/other.ts Show resolved Hide resolved

stackchain and others added 8 commits

October 17, 2023 04:38


          wip: metadata

wip

c6c9758


          add parseCompleteOrderMetadata helper

5b686c3


          add schema using zod

4e8185d


          rename const

0b365cc


          added parse safe helper

01ee5ae


          fix ts

2fc4ed7


          Fix(swap) refactor makePossibleMarketOrder helper (#2785)

535de53

stackchain force-pushed the fix/metadata-labels branch from a7423ae to 535de53 Compare

October 17, 2023 08:38

stackchain merged commit 3ca75f9 into develop

1 of 2 checks passed

stackchain deleted the fix/metadata-labels branch

October 17, 2023 09:03

stackchain mentioned this pull request

release: version 4.23.0-rc.9 #2821

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix