fix(swap): Fix swap cancellation fee error handling #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorbuedo
approved these changes
Oct 16, 2023
|
Lgtm. API said that order in particular was faulty and that's why cancellation doesn't work. |
jorbuedo
reviewed
Oct 16, 2023
apps/wallet-mobile/src/features/Swap/useCases/StartSwapScreen/ListOrders/OpenOrders.tsx
Show resolved
Hide resolved
stackchain
reviewed
Oct 16, 2023
| 460, | ||
| ) | ||
| } catch (error) { | ||
| if (error instanceof Error) { |
There was a problem hiding this comment.
Yes, error is unknown in the catch and we would not be able to access error.message
There was a problem hiding this comment.
in that case we need also an alert on the else side, if somewhere deep something else is thrown.
stackchain
reviewed
Oct 16, 2023
Comment on lines
246
to
247
| Alert.alert(strings.generalErrorTitle, strings.generalErrorMessage(error.message)) | ||
| } |
There was a problem hiding this comment.
Suggested change
| Alert.alert(strings.generalErrorTitle, strings.generalErrorMessage(error.message)) | |
| } | |
| Alert.alert(strings.generalErrorTitle, strings.generalErrorMessage(error.message)) | |
| } else { | |
| Alert.alert(strings.generalErrorTitle, strings.generalErrorMessage(/* stringify the error - default error unknown? */)) | |
| } |
There was a problem hiding this comment.
That's now updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://emurgo.atlassian.net/browse/YOMO-881
This PR only improves error handling, however there may be cases when the REST API does not respond with CBOR such as in this example
https://aggregator.muesliswap.com/cancelSwapTransaction/?wallet=01417232dba248bdd316442f323c4279fb1e0ef7bfb16680d8dabdd655f9ea671653e35395356465e4bd8f563b5d5480e4eb466da896a22afc&utxo=8956d68753d718afbaafde0e83dc1cb1d205da3c89fb08c924ab1d63fd953ed2%230&collateralUtxo=82825820926f781eea85507363790aca75e4e4a05ff6a0ad1c8b823db4074fd515b521a80082583901417232dba248bdd316442f323c4279fb1e0ef7bfb16680d8dabdd655f9ea671653e35395356465e4bd8f563b5d5480e4eb466da896a22afc1a001e8480