refactor(swap): improve swap buy field performance #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banklesss
commented
Oct 18, 2023
|
|
||
| if ((isSearching && assetSearchTerm.length > 0 && filteredTokensForList.length === 0) || allTokenInfos.length === 0) |
There was a problem hiding this comment.
When canallTokenInfos.length === 0) happen?
There was a problem hiding this comment.
Could it happen when the wallet has no tokens? But anyway, they should not be blocked from selecting the token to buy 🤔
There was a problem hiding this comment.
I have tested with a newly created wallet and the length value is 1 (ADA)
banklesss
force-pushed
the
refactor/improve-swap-buy-field-performance
branch
from
62a77fd to
cc0304a
Compare
…wap-buy-field-performance
banklesss
requested review from
stackchain,
jorbuedo,
SorinC6 and
michaeljscript
banklesss
commented
Oct 18, 2023
...reen/CreateOrder/EditBuyAmount/SelectBuyTokenFromListScreen/SelectBuyTokenFromListScreen.tsx
Outdated
Show resolved
Hide resolved
banklesss
commented
Oct 19, 2023
...reen/CreateOrder/EditBuyAmount/SelectBuyTokenFromListScreen/SelectBuyTokenFromListScreen.tsx
Outdated
Show resolved
Hide resolved
…CreateOrder/EditBuyAmount/SelectBuyTokenFromListScreen/SelectBuyTokenFromListScreen.tsx Signed-off-by: banklesss <[email protected]>
banklesss
commented
Oct 19, 2023
...reen/CreateOrder/EditBuyAmount/SelectBuyTokenFromListScreen/SelectBuyTokenFromListScreen.tsx
Outdated
Show resolved
Hide resolved
…CreateOrder/EditBuyAmount/SelectBuyTokenFromListScreen/SelectBuyTokenFromListScreen.tsx Signed-off-by: banklesss <[email protected]>
banklesss
force-pushed
the
refactor/improve-swap-buy-field-performance
branch
from
167f112 to
b15dcc1
Compare
stackchain
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to YOMO-859