Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(swap): pool actions modals #2797

Merged
merged 7 commits into from
Oct 19, 2023
Merged

refactor(swap): pool actions modals #2797

merged 7 commits into from
Oct 19, 2023

Conversation

banklesss
Copy link
Contributor

android

Screen.Recording.2023-10-19.at.04.04.36.mov

iOS

Simulator.Screen.Recording.-.iPhone.14.-.2023-10-19.at.04.02.49.mp4

@banklesss banklesss self-assigned this Oct 19, 2023
@banklesss banklesss added this to the 5.0.0 milestone Oct 19, 2023
@banklesss banklesss mentioned this pull request Oct 19, 2023
Merged
SorinC6
SorinC6 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@SorinC6 SorinC6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that on Android the title of the modal has gray color and IOS is as per design. I think we can force the color for it to keep it the same across platforms
Screenshot 2023-10-19 at 10 38 21

@stackchain
Copy link
Member

I see that on Android the title of the modal has gray color and IOS is as per design. I think we can force the color for it to keep it the same across platforms Screenshot 2023-10-19 at 10 38 21

I agree, @banklesss can you check it and fix the conflict pls.

@banklesss
Copy link
Contributor Author

fixed @SorinC6 @stackchain

image

@banklesss banklesss requested a review from SorinC6 October 19, 2023 10:12
@stackchain stackchain merged commit fb311b6 into develop Oct 19, 2023
2 checks passed
@stackchain stackchain deleted the refactor/swap-modal-pool-actions branch October 19, 2023 11:46
@stackchain stackchain mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljscript michaeljscript michaeljscript approved these changes

@jorbuedo jorbuedo Awaiting requested review from jorbuedo

@stackchain stackchain Awaiting requested review from stackchain

@SorinC6 SorinC6 Awaiting requested review from SorinC6

Assignees

@banklesss banklesss

Labels
refactor
Projects
None yet
Milestone
4.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@banklesss @stackchain @michaeljscript @SorinC6