chore: Added tests #2815
Merged
chore: Added tests #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackchain
force-pushed
the
chore/test-coverage
branch
from
350915f to
f1251d2
Compare
stackchain
commented
Oct 22, 2023
| draft.orderData.selectedPoolCalculation.sides.sell | ||
| } | ||
| draft.orderData.amounts.buy = | ||
| draft.orderData.selectedPoolCalculation.sides.buy |
There was a problem hiding this comment.
sides are already on the right side, and sell is locked (doesn't get updated), only buy needs update
stackchain
commented
Oct 22, 2023
| if (state.orderData.type === 'market') break | ||
|
|
||
| draft.orderData.limitPrice = action.limitPrice |
There was a problem hiding this comment.
branching earlier, price shouldn't be updated if type is not limit
stackchain
commented
Oct 22, 2023
| @@ -606,7 +600,7 @@ const orderReducer = ( | |||
| draft.orderData.calculations = makeOrderCalculations({ | |||
| orderType: state.orderData.type, | |||
| amounts: state.orderData.amounts, | |||
| limitPrice: state.orderData.limitPrice, | |||
| limitPrice: undefined, | |||
There was a problem hiding this comment.
if limit is passed it won't get updated, the if (shouldn't happen) the FFEE changes while creating an order, it must be reseted to market
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.