-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Tokens state #2823
Merged
Merged
refactor: Tokens state #2823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackchain
requested review from
SorinC6,
banklesss,
michaeljscript and
jorbuedo
October 24, 2023 09:50
|
stackchain
force-pushed
the
refactor/token-change-state
branch
from
October 24, 2023 14:50
060ae29
to
beba1f7
Compare
stackchain
force-pushed
the
refactor/token-change-state
branch
from
October 24, 2023 22:35
7cad31c
to
91621b7
Compare
banklesss
approved these changes
Oct 25, 2023
michaeljscript
approved these changes
Oct 25, 2023
jorbuedo
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some things to be corrected, but I'll fix them on another PR. Merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Later the Portfolio manager will change it, and the amounts will carry all info required, for now adding extra data to state
Relates to YOMO-902
Prices pre-calc are incorrect it can't be used yet, when adding fees (fees are in Lovelace) it needs conversion when adding it counting as non pt. I.e how much 2 ADA would be as MIN. (apples + bananas)