Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Tokens state #2823

Merged
merged 3 commits into from
Oct 25, 2023
Merged

refactor: Tokens state #2823

merged 3 commits into from
Oct 25, 2023

Conversation

stackchain
Copy link
Member

@stackchain stackchain commented Oct 24, 2023

  • Add partial token info to the state
  • Update the actions on UI
  • Apply the denomination on frontend fee calcs

Later the Portfolio manager will change it, and the amounts will carry all info required, for now adding extra data to state

Relates to YOMO-902


Prices pre-calc are incorrect it can't be used yet, when adding fees (fees are in Lovelace) it needs conversion when adding it counting as non pt. I.e how much 2 ADA would be as MIN. (apples + bananas)

@jorbuedo
Copy link
Contributor

⚠️ This PR will surely conflict with #2826

@stackchain stackchain force-pushed the refactor/token-change-state branch from 060ae29 to beba1f7 Compare October 24, 2023 14:50
@stackchain stackchain marked this pull request as ready for review October 24, 2023 22:32
@stackchain stackchain force-pushed the refactor/token-change-state branch from 7cad31c to 91621b7 Compare October 24, 2023 22:35
Copy link
Contributor

@jorbuedo jorbuedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some things to be corrected, but I'll fix them on another PR. Merging

@jorbuedo jorbuedo merged commit b0b5bde into develop Oct 25, 2023
@stackchain stackchain deleted the refactor/token-change-state branch February 6, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants