Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(collateral): Add collateral UX improvements #2965

Merged
merged 18 commits into from
Jan 10, 2024
Merged

fix(collateral): Add collateral UX improvements #2965

merged 18 commits into from
Jan 10, 2024

Conversation

michaeljscript
Copy link
Collaborator

@michaeljscript michaeljscript commented Jan 4, 2024 •
edited by jira bot
Loading

Resolves YOMO-1023

@michaeljscript michaeljscript changed the title fix(collateral): Add collateral UX improvements WIP: fix(collateral): Add collateral UX improvements Jan 4, 2024
@github-actions github-actions bot added the fix label Jan 4, 2024
@michaeljscript michaeljscript self-assigned this Jan 4, 2024
@michaeljscript michaeljscript marked this pull request as ready for review January 5, 2024 14:08
@michaeljscript michaeljscript changed the title WIP: fix(collateral): Add collateral UX improvements fix(collateral): Add collateral UX improvements Jan 5, 2024
@michaeljscript michaeljscript requested a review from lisicky January 5, 2024 15:14
@stackchain stackchain added this to the 4.25.0 milestone Jan 9, 2024
@michaeljscript
Copy link
Collaborator Author

@stackchain that's now updated and using hardcoded output index 0

@stackchain
Copy link
Member

@rahulnr7 it will require testing the collateral + swap order cancel.

@stackchain stackchain added refactor and removed fix labels Jan 10, 2024
@stackchain stackchain merged commit 2651062 into develop Jan 10, 2024
2 checks passed
@stackchain stackchain deleted the fix/collateral-improvements branch January 10, 2024 10:27
SorinC6 pushed a commit that referenced this pull request Jan 10, 2024
@michaeljscript @SorinC6
fix(collateral): Add collateral UX improvements (#2965)
6e6d2d3
@stackchain stackchain mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banklesss banklesss banklesss approved these changes

@stackchain stackchain stackchain approved these changes

@lisicky lisicky lisicky approved these changes

@jorbuedo jorbuedo Awaiting requested review from jorbuedo

@SorinC6 SorinC6 Awaiting requested review from SorinC6

Assignees

@michaeljscript michaeljscript

Labels
refactor
Projects
None yet
Milestone
4.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@michaeljscript @stackchain @lisicky @banklesss