fix: lifting action section #2966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banklesss
requested review from
jorbuedo,
michaeljscript,
stackchain and
SorinC6
jorbuedo
approved these changes
Jan 4, 2024
SorinC6
approved these changes
Jan 4, 2024
stackchain
reviewed
Jan 5, 2024
| @@ -54,73 +54,69 @@ export const DelegationConfirmation = () => { | |||
|
|
|||
| return ( | |||
| <View style={styles.container}> | |||
There was a problem hiding this comment.
is it a screen? if it is it should be wrapped within SafeAreaView.
There was a problem hiding this comment.
just checking and unfortunately the issue still persists
There was a problem hiding this comment.
also I tested using paddings instead of margins
There was a problem hiding this comment.
The problem is that the button stays behind the keyboard until you click to edit the input. When you start editing, the button goes into place.
I tried to force the focus but it didn't work either.
stackchain
reviewed
Jan 5, 2024
| </Actions> | ||
|
|
||
| {/* hack to fix weird KeyboardAvoidingView bug in THIS SCREEN */} | ||
| {Platform.OS === 'ios' && <KeyboardSpacer />} |
There was a problem hiding this comment.
maybe we should start using View.onLayout (thinking out loud, ignore it for now)
stackchain
force-pushed
the
fix/missing-ios-button-lift
branch
from
815e8ce to
3c558df
Compare
SorinC6
pushed a commit
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to YOMO-913