Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(history): Min-ada + section 1st row #2992

Merged
merged 1 commit into from
Jan 12, 2024
Merged

fix(history): Min-ada + section 1st row #2992

merged 1 commit into from
Jan 12, 2024

Conversation

stackchain
Copy link
Member

@stackchain stackchain commented Jan 12, 2024

Relates to: YOMO-1102

@github-actions github-actions bot added the fix label Jan 12, 2024
@@ -109,8 +110,7 @@ const styles = StyleSheet.create({
flex: 1,
},
dayHeaderRoot: {
paddingTop: 16,
paddingBottom: 8,
paddingBottom: 4,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paddingTop here was causing the first row to add 16 + 8 (spacer) between the locked deposit and tx history

@@ -48,6 +48,7 @@ export const TxHistoryList = (props: Props) => {
ItemSeparatorComponent={() => <Spacer height={16} />}
renderSectionHeader={({section: {data}}) => <DayHeader ts={data[0].submittedAt} />}
sections={groupedTransactions}
renderSectionFooter={() => <Spacer height={12} />}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the spacer here in thee footer, so the 1st row doesn't bloat blank space on screen

@stackchain stackchain added this to the 4.25.0 milestone Jan 12, 2024
@stackchain stackchain marked this pull request as ready for review January 12, 2024 12:03
@jorbuedo jorbuedo merged commit f4d1dc7 into develop Jan 12, 2024
2 checks passed
@jorbuedo jorbuedo deleted the fix/min-ada branch January 12, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants