Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet-mobile): tx history animation flick #3135

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

stackchain
Copy link
Member

@stackchain stackchain commented Mar 14, 2024

  • The Animated.View was conflicting with the react-native-navigation default animation, therefore both animations were fighting to complete
  • If its needed to translate X/Y it needs to happen on the navigation animation (route)
  • Fixed the StatusBar on qr-code (it was hidden it), yet it should be always dark as the QR code screen, otherwise it shows the background of it.

Relates to #3219

@github-actions github-actions bot added the fix label Mar 14, 2024
@stackchain
Copy link
Member Author

@jorbuedo can you test it?

@stackchain stackchain added this to the 4.26.0 milestone Mar 14, 2024
@stackchain stackchain marked this pull request as ready for review March 14, 2024 14:57
@@ -57,69 +53,67 @@ export const TxHistory = () => {

return (
<View style={styles.scrollView}>
<Animated.View style={[styles.container, translateStyles]}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we've decided not to use the custom animation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yap Product just approved, it will be done later - in the navigation.

@stackchain stackchain merged commit 8a7afb8 into develop Mar 14, 2024
3 checks passed
@stackchain stackchain deleted the fix/tx-animation branch March 14, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants