feature(wallet-mobile): Redirect universal & deeplinks #3155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackchain
commented
Mar 22, 2024
|
|
||
| import {AppRegistry} from 'react-native' | ||
|
|
||
| import {name} from './app.json' | ||
| import {YoroiApp} from './src/YoroiApp' | ||
|
|
||
| enableMapSet() |
There was a problem hiding this comment.
it makes immer works with sets and maps
stackchain
commented
Mar 22, 2024
|
|
||
| const {setInitialUrl, initialUrl} = useInitialLink() | ||
| // exchange | ||
| const exchangeManager = React.useMemo(() => { |
There was a problem hiding this comment.
the modal was consuming from a context that doesn't exist
stackchain
commented
Mar 22, 2024
| // exchange | ||
| const exchangeManager = React.useMemo(() => { | ||
| const api = exchangeApiMaker({ | ||
| isProduction: action?.info?.params?.isSandbox !== true, |
There was a problem hiding this comment.
partners should pass isSandbox to avoid misleading actions
stackchain
commented
Mar 22, 2024
| @@ -0,0 +1,6 @@ | |||
| import {freeze} from 'immer' | |||
|
|
|||
| export const knownApps: Readonly<Map<string, {name: string; vkey: string}>> = freeze( | |||
There was a problem hiding this comment.
explanation in confluence, for trusted communication between client and app.
stackchain
commented
Mar 22, 2024
| ) | ||
|
|
||
| const value = React.useMemo( |
There was a problem hiding this comment.
theme is everywhere and it rarely changes, memoized
stackchain
force-pushed
the
feature/redirect-universal-deeplink
branch
from
fe33067 to
e300892
Compare
banklesss
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.