feature(exchange): loading error screens #3158
Conversation
…oading-error-screens
…oading-error-screens
There was a problem hiding this comment.
A modal inspired by the one we already had has been created but exclusively for loading, since it is the new design that occupies the entire screen
banklesss
requested review from
jorbuedo,
michaeljscript,
stackchain and
SorinC6
| } | ||
| } | ||
|
|
||
| const defaultState: LoadingOverlayState = Object.freeze({ |
There was a problem hiding this comment.
Why object.freeze?
There was a problem hiding this comment.
To force immutability
There was a problem hiding this comment.
Is there a convention when to use Object.freeze and when not? Otherwise all constants could have object.freeze. In this case, it seems to me it's quite unnecessary
|
|
||
| const handleStartLoading = React.useCallback( | ||
| (text: LoadingOverlayState['text']) => { | ||
| timerRef.current = setTimeout(() => startLoading(text), delays) |
There was a problem hiding this comment.
Should we add a check if the component is still mounted? Eg if user navigates back while it's loading
There was a problem hiding this comment.
If its loading, the button will be disabled so the user can't perform the loading action again
There was a problem hiding this comment.
What if they press the hardware button?
apps/wallet-mobile/src/components/LoadingOverlay/LoadingOverlayContext.tsx
Show resolved
Hide resolved
|
waiting for loading screens redesign |
|
closed in favour of #3563 |
Related to YOMO-1256
In the demo below the error and loading time have been forced
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-03-24.at.13.52.48.mp4