feature(wallet-mobile): dApp explorer #3170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @lephuochoai , I've left a comment/question on Slack regarding the modals and dApp web browser. Please let me know if something is unclear. |
lephuochoai
force-pushed
the
feat-dapp-explorer
branch
from
bd12034 to
ac4040f
Compare
There was a problem hiding this comment.
Hello @lephuochoai, the changes look great and work very well, including the amazing animations in browser view. Good job! I've suggested a few minor improvements. Feel free to let me know if something is unclear or just want to confirm anything. Many thanks!
apps/wallet-mobile/src/features/Discovery/common/useDAppsConnected.tsx
Outdated
Show resolved
Hide resolved
apps/wallet-mobile/src/features/Discovery/common/Browser/BrowserTabBar.tsx
Outdated
Show resolved
Hide resolved
apps/wallet-mobile/src/features/Discovery/common/Browser/BrowserSearchToolbar.tsx
Outdated
Show resolved
Hide resolved
apps/wallet-mobile/src/features/Discovery/common/Browser/BrowserProvider.tsx
Outdated
Show resolved
Hide resolved
apps/wallet-mobile/src/features/Discovery/useCases/DiscoverList/DAppTypes/DAppTypes.tsx
Outdated
Show resolved
Hide resolved
apps/wallet-mobile/src/features/Discovery/common/LabelConnected.tsx
Outdated
Show resolved
Hide resolved
apps/wallet-mobile/src/features/Discovery/useCases/Browser/WebViewItem.tsx
Outdated
Show resolved
Hide resolved
...ile/src/features/Discovery/useCases/DiscoverList/CountDAppsAvailable/CountDAppsAvailable.tsx
Outdated
Show resolved
Hide resolved
apps/wallet-mobile/src/features/Discovery/useCases/DiscoverList/DAppTypes/DAppTypes.tsx
Outdated
Show resolved
Hide resolved
apps/wallet-mobile/src/features/Discovery/useCases/DiscoverList/DAppItem/DAppItem.tsx
Outdated
Show resolved
Hide resolved
apps/wallet-mobile/src/features/Discovery/useCases/DiscoverList/DAppItem/DAppItem.tsx
Outdated
Show resolved
Hide resolved
apps/wallet-mobile/src/features/Discover/useCases/BrowseDappScreen/BrowserToolbar.tsx
Outdated
Show resolved
Hide resolved
apps/wallet-mobile/src/features/Discover/useCases/BrowseDappScreen/BrowserTabsBar.tsx
Outdated
Show resolved
Hide resolved
apps/wallet-mobile/src/features/Discover/useCases/DiscoverListScreen/DAppItem/DAppItem.tsx
Outdated
Show resolved
Hide resolved
apps/wallet-mobile/src/features/Discover/useCases/BrowseDappScreen/BrowserSearchToolbar.tsx
Outdated
Show resolved
Hide resolved
michaeljscript
approved these changes
Apr 11, 2024
|
favour #3189 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.